Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Picker 컴포넌트 구현 #139

Merged
merged 53 commits into from
Aug 30, 2024
Merged

[Feature] Picker 컴포넌트 구현 #139

merged 53 commits into from
Aug 30, 2024

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Aug 12, 2024 •
edited
Loading

🎉 변경 사항

  • SingleDatePicker, RangeDatePicker, TimePicker 컴포넌트를 구현했습니다.
  • SingleDatePicker와 TimePicker는 PickerGroup으로 묶어서 하나의 Date 객체로 관리할 수 있습니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

  • table에서 행간을 설정하는 데 실패해서 해당 부분 css가 디자인과 다릅니다. (border-spacing 속성이 안먹더라구요. 혹시 방법 아시는 분..)
  • 24시간을 조절하는 것이 아니라 AM과 PM이 나뉘어져 있어 12시 관련 엣지케이스가 발생했습니다. 해당 부분 유의해서 봐주시면 감사하겠습니다.

@hamo-o hamo-o self-assigned this Aug 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-tzwjdiejad.chromatic.com/

@hamo-o hamo-o linked an issue Aug 12, 2024 that may be closed by this pull request
[Feature] Picker 컴포넌트 구현 #137
Closed
2 tasks
@hamo-o hamo-o marked this pull request as ready for review August 21, 2024 15:32
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-coptuoloue.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-clkeejhrpu.chromatic.com/

eugene028

This comment was marked as off-topic.

Sign in to view

eugene028
eugene028 reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

packages/wow-ui/src/components/Picker/DatePicker.stories.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Picker/DateDropDown.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Picker/DateDropDown.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/RangeDatePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/RangeDatePicker.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Picker/RangeDatePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/TimePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/TimePicker.tsx Outdated Show resolved Hide resolved
ghdtjgus76
ghdtjgus76 reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~

packages/wow-ui/src/utils/changeDateToString.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/pickerComponents.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/PickerContext.ts Show resolved Hide resolved
packages/wow-ui/src/components/Picker/DateDropDown.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/DatePicker.stories.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Picker/RangeDatePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/TimePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/TimePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/TimePicker.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Picker/pickerComponents.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-zmqfgbxbtm.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ncvqprunhx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-kuvazxkrgb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-mtqsyqbdyt.chromatic.com/

@hamo-o hamo-o requested review from eugene028 and ghdtjgus76 August 26, 2024 22:15
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-pwrzjdaory.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ldvryvtwbg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-uyhpzxonoj.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

eugene028
eugene028 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 수고많으셨습니다!

hamo-o added 24 commits August 30, 2024 17:38
@hamo-o
chore: PickerGroup 빌드
2972b7f
@hamo-o
fix: a11y color-contrast 체크 해제
17f6a98
@hamo-o
refactor: Date to string 유틸함수 사용하기
9c39d01
@hamo-o
refactor: pickerClassNames 분리
a6ae6d0
@hamo-o
refactor: pickerComponents 분리
de41e57
@hamo-o
rename: 폴더구조 변경
1b3b033
@hamo-o
chore: 빌드 내용 추가
69795f7
@hamo-o
fix: 복잡한 삼항연산자 개선 및 빌드 에러를 해결하기 위한 폴더구조 재변경
c851d59
@hamo-o
refactor: 여러번 호출되는 getHours 개선
516bda5
@hamo-o
fix: styled와 className 통일 및 불필요한 styled 삭제
03bddc5
@hamo-o
feat: 시작, 끝 날짜 선택 후 재선택 시 초기화
c2985d1
@hamo-o
refactor: format~ 으로 함수 네이밍 변경
45ecd85
@hamo-o
refactor: format~ 함수 util로 분리
d9e6f89
@hamo-o
refactor: useTimeState 훅 분리
41c4c14
@hamo-o
refactor: formatDateToString return값 변경
ddefb56
@hamo-o
fix: 타입 단언 제거
575dae2
@hamo-o
chore: pickerComponents 빌드 제외
a28105f
@hamo-o
chore: package.json 변경 및 rollup config 변경
c2c38fe
@hamo-o
chore: 스토리북 console.log 삭제
f79680f
@hamo-o
feat: DatePicker 바깥 영역 클릭 시 드롭다운 닫기
3d6be3e
@hamo-o
chore: changeset 추가
f9936b3
@hamo-o
design: TimePicker select 및 active 시 디자인 적용
52365aa
@hamo-o
chore: 불필요한 닫는 태그 삭제
2c6ae10
@hamo-o
refactor: useTimeState 훅 코드리뷰 반영
3e3c2fc
@hamo-o hamo-o force-pushed the feature/date-picker-component branch from 0aa29cd to 3e3c2fc Compare August 30, 2024 08:39
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-dmnwxtmjdx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-wctzmkjwmd.chromatic.com/

@hamo-o hamo-o merged commit f65c5d8 into main Aug 30, 2024
3 checks passed
@hamo-o hamo-o deleted the feature/date-picker-component branch August 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 eugene028 approved these changes

@SeieunYoo SeieunYoo Awaiting requested review from SeieunYoo SeieunYoo is a code owner

Assignees

@hamo-o hamo-o

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Picker 컴포넌트 구현
3 participants
@hamo-o @eugene028 @ghdtjgus76